src: add receiver to fast api callback methods by Ceres6 · Pull Request #54408 · nodejs/node

@Ceres6

When creating an fast api the callback might use the receiver. In that
case if the internal binding is destructured the method won't have
access to the reciver and it will throw. Passing the receiver as second
argument ensures the receiver is available.

@nodejs-github-bot added lib / src

Issues and PRs related to general changes in the lib or src directory.

needs-ci

PRs that need a full CI run.

labels

Aug 16, 2024

@Ceres6 Ceres6 marked this pull request as draft

August 16, 2024 11:22

joyeecheung

@Ceres6

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

@Ceres6 Ceres6 marked this pull request as ready for review

September 24, 2024 09:43

Qard

Qard approved these changes Sep 24, 2024

avivkeller

joyeecheung

@Ceres6 @avivkeller

Co-authored-by: Aviv Keller <redyetidev@gmail.com>

santigimeno

@aduh95 aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Sep 27, 2024

@mcollina mcollina added commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Sep 28, 2024

targos pushed a commit that referenced this pull request

Oct 4, 2024
When creating an fast api the callback might use the receiver. In that
case if the internal binding is destructured the method won't have
access to the reciver and it will throw. Passing the receiver as second
argument ensures the receiver is available.

PR-URL: #54408
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

targos pushed a commit that referenced this pull request

Oct 4, 2024
When creating an fast api the callback might use the receiver. In that
case if the internal binding is destructured the method won't have
access to the reciver and it will throw. Passing the receiver as second
argument ensures the receiver is available.

PR-URL: #54408
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

louwers pushed a commit to louwers/node that referenced this pull request

Nov 2, 2024
When creating an fast api the callback might use the receiver. In that
case if the internal binding is destructured the method won't have
access to the reciver and it will throw. Passing the receiver as second
argument ensures the receiver is available.

PR-URL: nodejs#54408
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Nov 20, 2024

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request

Nov 21, 2024
When creating an fast api the callback might use the receiver. In that
case if the internal binding is destructured the method won't have
access to the reciver and it will throw. Passing the receiver as second
argument ensures the receiver is available.

PR-URL: nodejs#54408
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Nov 21, 2024

codebytere added a commit to electron/electron that referenced this pull request

Dec 3, 2024

codebytere added a commit to electron/electron that referenced this pull request

Dec 4, 2024

codebytere added a commit to electron/electron that referenced this pull request

Jan 22, 2025

samuelmaddock pushed a commit to electron/electron that referenced this pull request

Jan 22, 2025
* chore: bump node in DEPS to v22.11.0

* src: move evp stuff to ncrypto

nodejs/node#54911

* crypto: add Date fields for validTo and validFrom

nodejs/node#54159

* module: fix discrepancy between .ts and .js

nodejs/node#54461

* esm: do not interpret "main" as a URL

nodejs/node#55003

* src: modernize likely/unlikely hints

nodejs/node#55155

* chore: update patch indices

* crypto: add validFromDate and validToDate fields to X509Certificate

nodejs/node#54159

* chore: fixup perfetto patch

* fix: clang warning in simdjson

* src: add receiver to fast api callback methods

nodejs/node#54408

* chore: fixup revert patch

* fixup! esm: do not interpret "main" as a URL

* fixup! crypto: add Date fields for validTo and validFrom

* fix: move ArrayBuffer test patch

* src: fixup Error.stackTraceLimit during snapshot building

nodejs/node#55121

* fix: bad rebase

* chore: fixup amaro

* chore: address feedback from review

* src: revert filesystem::path changes

nodejs/node#55015

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Feb 3, 2025

codebytere added a commit to electron/electron that referenced this pull request

Feb 10, 2025

codebytere added a commit to electron/electron that referenced this pull request

Feb 10, 2025

codebytere added a commit to electron/electron that referenced this pull request

Feb 14, 2025

codebytere added a commit to electron/electron that referenced this pull request

Feb 14, 2025
* chore: bump node in DEPS to v22.13.0

* chore: bump node in DEPS to v22.13.1

* src: move evp stuff to ncrypto

nodejs/node#54911

* crypto: add Date fields for validTo and validFrom

nodejs/node#54159

* module: fix discrepancy between .ts and .js

nodejs/node#54461

* esm: do not interpret "main" as a URL

nodejs/node#55003

* src: modernize likely/unlikely hints

nodejs/node#55155

* chore: update patch indices

* crypto: add validFromDate and validToDate fields to X509Certificate

nodejs/node#54159

* chore: fixup perfetto patch

* fix: clang warning in simdjson

* src: add receiver to fast api callback methods

nodejs/node#54408

* chore: fixup revert patch

* fixup! esm: do not interpret "main" as a URL

* fixup! crypto: add Date fields for validTo and validFrom

* fix: move ArrayBuffer test patch

* src: fixup Error.stackTraceLimit during snapshot building

nodejs/node#55121

* fix: bad rebase

* chore: fixup amaro

* chore: address feedback from review

* src: revert filesystem::path changes

nodejs/node#55015

* chore: fixup GN build file

* nodejs/node#55529
* nodejs/node#55798
* nodejs/node#55530

* module: simplify --inspect-brk handling

nodejs/node#55679

* src: fix outdated js2c.cc references

nodejs/node#56133

* crypto: include openssl/rand.h explicitly

nodejs/node#55425

* build: use variable for crypto dep path

nodejs/node#55928

* crypto: fix RSA_PKCS1_PADDING error message

nodejs/node#55629

* build: use variable for simdutf path

nodejs/node#56196

* test,crypto: make crypto tests work with BoringSSL

nodejs/node#55491

* fix: suppress clang -Wdeprecated-declarations in libuv

libuv/libuv#4486

* deps: update libuv to 1.49.1

nodejs/node#55114

* test: make test-node-output-v8-warning more flexible

nodejs/node#55401

* [v22.x] Revert "v8: enable maglev on supported architectures"

nodejs/node#54384

* fix: potential WIN32_LEAN_AND_MEAN redefinition

c-ares/c-ares#869

* deps: update nghttp2 to 1.64.0

nodejs/node#55559

* src: provide workaround for container-overflow

nodejs/node#55591

* build: use variable for simdutf path

nodejs/node#56196

* chore: fixup patch indices

* fixup! module: simplify --inspect-brk handling

* lib: fix fs.readdir recursive async

nodejs/node#56041

* lib: avoid excluding symlinks in recursive fs.readdir with filetypes

nodejs/node#55714

This doesn't currently play well with ASAR - this should be fixed in a follow up

* test: disable CJS permission test for config.main

This has diverged as a result of our revert of
src,lb: reducing C++ calls of esm legacy main resolve

* fixup! lib: fix fs.readdir recursive async

* deps: update libuv to 1.49.1

nodejs/node#55114

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

cyyynthia added a commit to cyyynthia/node that referenced this pull request

Apr 6, 2025
The check was incorrectly altered in nodejs#54408, passing the bindings as argument for `this` instead of the path string.
This check not working having no significant impact on Node.js as far as I can tell, this changes removes it altogether to avoid undesired overhead.

Signed-off-by: Cynthia Rey <cynthia@cynthia.dev>

cyyynthia added a commit to cyyynthia/node that referenced this pull request

Apr 6, 2025
The check was incorrectly altered in nodejs#54408, passing the bindings as
argument for `this` instead of the path string. This check not working
having no significant impact on Node.js as far as I can tell, this
change removes it altogether to avoid undesired overhead.

Signed-off-by: Cynthia Rey <cynthia@cynthia.dev>

cyyynthia added a commit to cyyynthia/node that referenced this pull request

Apr 11, 2025
The check was incorrectly altered in nodejs#54408, passing the bindings as
argument for `this` instead of the path string.

Signed-off-by: Cynthia Rey <cynthia@cynthia.dev>