esm: do not interpret `"main"` as a URL by aduh95 · Pull Request #55003 · nodejs/node

esm: do not interpret `"main"` as a URL by aduh95 · Pull Request #55003 · nodejs/node

As documented, its value is a path.

added c++

Issues and PRs that require attention from people who are familiar with C++.

Issues and PRs related to the ECMAScript Modules implementation.

Issues and PRs related to the fs subsystem / file system.

PRs that need a full CI run.

labels

aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

Add this label to start a Jenkins CI on a PR.

labels

aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

targos pushed a commit that referenced this pull request

As documented, its value is a path.

PR-URL: #55003
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

targos pushed a commit that referenced this pull request

As documented, its value is a path.

PR-URL: #55003
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

louwers pushed a commit to louwers/node that referenced this pull request

As documented, its value is a path.

PR-URL: nodejs#55003
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request

As documented, its value is a path.

PR-URL: nodejs#55003
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

samuelmaddock pushed a commit to electron/electron that referenced this pull request

* chore: bump node in DEPS to v22.11.0

* src: move evp stuff to ncrypto

nodejs/node#54911

* crypto: add Date fields for validTo and validFrom

nodejs/node#54159

* module: fix discrepancy between .ts and .js

nodejs/node#54461

* esm: do not interpret "main" as a URL

nodejs/node#55003

* src: modernize likely/unlikely hints

nodejs/node#55155

* chore: update patch indices

* crypto: add validFromDate and validToDate fields to X509Certificate

nodejs/node#54159

* chore: fixup perfetto patch

* fix: clang warning in simdjson

* src: add receiver to fast api callback methods

nodejs/node#54408

* chore: fixup revert patch

* fixup! esm: do not interpret "main" as a URL

* fixup! crypto: add Date fields for validTo and validFrom

* fix: move ArrayBuffer test patch

* src: fixup Error.stackTraceLimit during snapshot building

nodejs/node#55121

* fix: bad rebase

* chore: fixup amaro

* chore: address feedback from review

* src: revert filesystem::path changes

nodejs/node#55015

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

* chore: bump node in DEPS to v22.13.0

* chore: bump node in DEPS to v22.13.1

* src: move evp stuff to ncrypto

nodejs/node#54911

* crypto: add Date fields for validTo and validFrom

nodejs/node#54159

* module: fix discrepancy between .ts and .js

nodejs/node#54461

* esm: do not interpret "main" as a URL

nodejs/node#55003

* src: modernize likely/unlikely hints

nodejs/node#55155

* chore: update patch indices

* crypto: add validFromDate and validToDate fields to X509Certificate

nodejs/node#54159

* chore: fixup perfetto patch

* fix: clang warning in simdjson

* src: add receiver to fast api callback methods

nodejs/node#54408

* chore: fixup revert patch

* fixup! esm: do not interpret "main" as a URL

* fixup! crypto: add Date fields for validTo and validFrom

* fix: move ArrayBuffer test patch

* src: fixup Error.stackTraceLimit during snapshot building

nodejs/node#55121

* fix: bad rebase

* chore: fixup amaro

* chore: address feedback from review

* src: revert filesystem::path changes

nodejs/node#55015

* chore: fixup GN build file

* nodejs/node#55529
* nodejs/node#55798
* nodejs/node#55530

* module: simplify --inspect-brk handling

nodejs/node#55679

* src: fix outdated js2c.cc references

nodejs/node#56133

* crypto: include openssl/rand.h explicitly

nodejs/node#55425

* build: use variable for crypto dep path

nodejs/node#55928

* crypto: fix RSA_PKCS1_PADDING error message

nodejs/node#55629

* build: use variable for simdutf path

nodejs/node#56196

* test,crypto: make crypto tests work with BoringSSL

nodejs/node#55491

* fix: suppress clang -Wdeprecated-declarations in libuv

libuv/libuv#4486

* deps: update libuv to 1.49.1

nodejs/node#55114

* test: make test-node-output-v8-warning more flexible

nodejs/node#55401

* [v22.x] Revert "v8: enable maglev on supported architectures"

nodejs/node#54384

* fix: potential WIN32_LEAN_AND_MEAN redefinition

c-ares/c-ares#869

* deps: update nghttp2 to 1.64.0

nodejs/node#55559

* src: provide workaround for container-overflow

nodejs/node#55591

* build: use variable for simdutf path

nodejs/node#56196

* chore: fixup patch indices

* fixup! module: simplify --inspect-brk handling

* lib: fix fs.readdir recursive async

nodejs/node#56041

* lib: avoid excluding symlinks in recursive fs.readdir with filetypes

nodejs/node#55714

This doesn't currently play well with ASAR - this should be fixed in a follow up

* test: disable CJS permission test for config.main

This has diverged as a result of our revert of
src,lb: reducing C++ calls of esm legacy main resolve

* fixup! lib: fix fs.readdir recursive async

* deps: update libuv to 1.49.1

nodejs/node#55114

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>