Home Original page

doc: fix crypto update() signatures by mscdex · Pull Request #5500 · nodejs/node

@mscdex added crypto

Issues and PRs related to the crypto subsystem.

doc

Issues and PRs related to the documentations.

labels

Mar 1, 2016

@mscdex mscdex changed the title doc: fix crypto hash.update() signature doc: fix crypto update() signatures

Mar 1, 2016

@mscdex 

PR-URL: nodejs#5500
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

@mscdex mscdex deleted the doc-crypto-fix-hmac-update-signature branch

March 18, 2016 02:38

Fishrock123 pushed a commit that referenced this pull request

Mar 22, 2016 
PR-URL: #5500
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

MylesBorins pushed a commit that referenced this pull request

Mar 30, 2016 
PR-URL: #5500
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

MylesBorins pushed a commit that referenced this pull request

Mar 30, 2016 
PR-URL: #5500
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

addaleax added a commit to addaleax/node that referenced this pull request

Jul 19, 2016 
The default encoding for crypto methods was changed in v6.0.0,
with v4.x keeping a default of `binary`.

Ref: nodejs#5500
Fixes: nodejs#7712

jasnell pushed a commit that referenced this pull request

Aug 1, 2016 
The default encoding for crypto methods was changed in v6.0.0,
with v4.x keeping a default of `binary`.

Ref: #5500
Fixes: #7712
PR-URL: #7799
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

lmoe pushed a commit to lmoe/node that referenced this pull request

Feb 16, 2017 
PullRequest nodejs#5522 and nodejs#5500 described the change
of the default encoding into UTF8 in crypto functions.

This however was only changed for the non-streaming API.
The streaming API still used binary as the default encoding.

This commit will change the default streaming API encoding to UTF8
to make both APIs behave the same.

It will also add tests to validate the behavior.

addaleax pushed a commit that referenced this pull request

Mar 11, 2017 
PullRequest #5522 and #5500 described the change
of the default encoding into UTF8 in crypto functions.

This however was only changed for the non-streaming API.
The streaming API still used binary as the default encoding.

This commit will change the default streaming API encoding to UTF8
to make both APIs behave the same.

It will also add tests to validate the behavior.

Refs: #5522
Refs: #5500
PR-URL: #8611
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

jungx098 pushed a commit to jungx098/node that referenced this pull request

Mar 21, 2017 
PullRequest nodejs#5522 and nodejs#5500 described the change
of the default encoding into UTF8 in crypto functions.

This however was only changed for the non-streaming API.
The streaming API still used binary as the default encoding.

This commit will change the default streaming API encoding to UTF8
to make both APIs behave the same.

It will also add tests to validate the behavior.

Refs: nodejs#5522
Refs: nodejs#5500
PR-URL: nodejs#8611
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>