doc: correct crypto encoding information (v4.x) by addaleax · Pull Request #7799 · nodejs/node

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@addaleax

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The default encoding for crypto methods was changed in v6.0.0, with v4.x keeping a default of binary.

Ref: #5500
Fixes: #7712

The default encoding for crypto methods was changed in v6.0.0,
with v4.x keeping a default of `binary`.

Ref: nodejs#5500
Fixes: nodejs#7712

@addaleax addaleax added crypto

Issues and PRs related to the crypto subsystem.

doc

Issues and PRs related to the documentations.

v4.x labels

Jul 19, 2016

@addaleax addaleax changed the title doc: correct crypto encoding information doc: correct crypto encoding information (v4.x)

Jul 19, 2016

@claudiorodriguez

@bnoordhuis

LGTM. Perhaps the documentation could be explicit about the fact that the default encoding changed in v6?

Aside: 'enforced' is a bit of an odd choice of words.

@addaleax

I’ve updated with “implied” substituted where “enforced” is currently being used. And +1 to being explicit about the change in v6, but that should probably go into a different PR against master.

@MylesBorins

@addaleax is this important enough to be rolled into v4.5.0 or could it wait for the next patch release?

@addaleax

@thealphanerd uff… doesn’t really matter? It can wait, but it’s a only a correction in the docs.

@jasnell

jasnell pushed a commit that referenced this pull request

Aug 1, 2016
The default encoding for crypto methods was changed in v6.0.0,
with v4.x keeping a default of `binary`.

Ref: #5500
Fixes: #7712
PR-URL: #7799
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell

Labels

crypto

Issues and PRs related to the crypto subsystem.

doc

Issues and PRs related to the documentations.