doc: correct crypto encoding information (v4.x) by addaleax · Pull Request #7799 · nodejs/node
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 35.1k
Conversation
The default encoding for crypto methods was changed in v6.0.0, with v4.x keeping a default of `binary`. Ref: nodejs#5500 Fixes: nodejs#7712
v4.x labels
Jul 19, 2016
addaleax
changed the title
doc: correct crypto encoding information
doc: correct crypto encoding information (v4.x)
LGTM. Perhaps the documentation could be explicit about the fact that the default encoding changed in v6?
Aside: 'enforced' is a bit of an odd choice of words.
I’ve updated with “implied” substituted where “enforced” is currently being used. And +1 to being explicit about the change in v6, but that should probably go into a different PR against master.
@addaleax is this important enough to be rolled into v4.5.0 or could it wait for the next patch release?
@thealphanerd uff… doesn’t really matter? It can wait, but it’s a only a correction in the docs.
jasnell pushed a commit that referenced this pull request
Aug 1, 2016This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters