feat(Masthead): Updates for new masthead structure in Penta by tlabaj · Pull Request #10809 · patternfly/patternfly-react

Conversation

@tlabaj

What: Closes #10788

  • Renamed MastheadBrand to MastheadLogo
  • Renamed MastheadMain to MastheadBrand
  • Wrap MastheadToggle and MastheadBrand in MastheadMain

Codemod issue: patternfly/pf-codemods#718

@patternfly-build

@tlabaj tlabaj linked an issue

Jul 26, 2024

that may be closed by this pull request

wise-king-sullyman

srambach

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surge is down so I haven't run it yet but had a couple of questions. Otherwise looks good on inspection!

edonehoo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since surge is down, this is going off the file changes as best I can. can re-review if/when surge comes back to make sure I checked everything, but this probably covers the main things regardless!

thatblindgeye

edonehoo

kmcfaul

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We may want to open a follow up in org if we don't already have one to update the structure for the docs site (the surge masthead is the old structure still).

andrew-ronaldson

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

srambach

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ⭐

@patternfly-build

Your changes have been released in:

  • @patternfly/react-charts@8.0.0-alpha.35
  • @patternfly/react-code-editor@6.0.0-alpha.93
  • @patternfly/react-core@6.0.0-alpha.93
  • @patternfly/react-docs@7.0.0-alpha.101
  • @patternfly/react-drag-drop@6.0.0-alpha.75
  • @patternfly/react-icons@6.0.0-alpha.33
  • @patternfly/react-integration@6.0.0-alpha.47
  • demo-app-ts@5.1.1-alpha.92
  • @patternfly/react-styles@6.0.0-alpha.32
  • @patternfly/react-table@6.0.0-alpha.94
  • @patternfly/react-templates@6.0.0-alpha.43
  • @patternfly/react-tokens@6.0.0-alpha.32

Thanks for your contribution! 🎉

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@srambach srambach srambach approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

+1 more reviewer

@edonehoo edonehoo edonehoo approved these changes

Reviewers whose approvals may not affect merge requirements