feat(ext): expose GoValue() and PHPValue() functions by dunglas · Pull Request #1877 · php/frankenphp
Navigation Menu
{{ message }}
php / frankenphp Public
- Notifications You must be signed in to change notification settings
- Fork 444
Merged
feat(ext): expose GoValue() and PHPValue() functions#1877
feat(ext): expose GoValue() and PHPValue() functions#1877
Conversation
Copy link Copy Markdown
Member
dunglas
commented
Sep 15, 2025
dunglas
commented
Also, clarify the docs and optimize map creation.
dunglas
requested a review
from alexandre-daubois
dunglas
force-pushed
the
feat/GoValue
branch
from
9fb6e83 to
e63c8fb
Compare
alexandre-daubois approved these changes Sep 15, 2025
Copy link Copy Markdown
Member
alexandre-daubois
left a comment
alexandre-daubois
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's better to me as well! LGTM if CI is green 👍
Copy link Copy Markdown
Member
alexandre-daubois
commented
Sep 15, 2025
alexandre-daubois commented
Sep 15, 2025Should the docs of extgen be updated as well?
withinboredom approved these changes Sep 15, 2025
dunglas
changed the title
feat(ext): expose a GoValue function
feat(ext): expose GoValue() and PHPValue() functions
dunglas
deleted the
feat/GoValue
branch
dunglas
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants