fix: PHPValue() and GoValue() types by dunglas · Pull Request #1879 · php/frankenphp

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@dunglas

Copy link Copy Markdown

Member

@dunglas dunglas commented

Sep 15, 2025

Fix a type issue I introduced in #1877

@dunglas dunglas changed the title fix: PHPValue() return type fix: PHPValue() and GoValue() types

Sep 15, 2025
Copy link Copy Markdown

Member

@withinboredom withinboredom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:try-not-to-cry.gif:

@dunglas dunglas merged commit 7754abc into main

Sep 15, 2025

23 checks passed

@dunglas dunglas deleted the fix/PHPValue-type branch

September 15, 2025 15:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@withinboredom withinboredom withinboredom approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dunglas @withinboredom @alexandre-daubois