Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)" by vstinner · Pull Request #13329 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13329
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:revert_asyncio
Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13329
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:revert_asyncio
Conversation
vstinner
requested review from
1st1,
asvetlov and
gpshead
as code owners
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
asvetlov approved these changes May 14, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
vstinner
mentioned this pull request
Copy link Copy Markdown
Member Author
vstinner
commented
May 14, 2019
vstinner commented
May 14, 2019I already reverted the change in 3.7: PR #13328.
The revert in master is motivated by https://bugs.python.org/issue36870 : test_asyncio fails randomly which causes a lot of pain in the Python CI and the Python workflow.
I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870
Copy link Copy Markdown
Contributor
asvetlov
commented
May 14, 2019
asvetlov commented
May 14, 2019I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870
I guess no, the PR #13313 doesn't fix your issue.
This pull request is necessary (but please don't revert #13313 and #13099)
Copy link Copy Markdown
Contributor
asvetlov
commented
May 14, 2019
asvetlov commented
May 14, 2019#13330 is a minimal change that reverts StreamWriter.drain() on the master to code that was working properly.
I suggest to use it instead, tests should pass
Copy link Copy Markdown
Member Author
vstinner
commented
May 14, 2019
vstinner commented
May 14, 2019I suggest to use it instead, tests should pass
Honestly, I don't care: it's up to you, as soon as test_asyncio pass: as soon as https://bugs.python.org/issue36870 is fixed.
Copy link Copy Markdown
Member Author
vstinner
commented
May 14, 2019
vstinner commented
May 14, 2019
vstinner
closed this
vstinner
deleted the
revert_asyncio
branch
asvetlov
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment