Home Original page

[2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) by tirkarthi · Pull Request #13426 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tirkarthi

Copy link Copy Markdown

Member

@tirkarthi tirkarthi commented

May 19, 2019

•

edited by bedevere-bot

Loading

This is a manual backport of ca7fe50 since 2.7 has http.cookiejar in cookielib

https://bugs.python.org/issue35121

@tirkarthi

Copy link Copy Markdown

Member Author

Requesting review from @benjaminp since this is a manual backport of the security fix in 3.x branch

@tirkarthi tirkarthi closed this

May 19, 2019

@tirkarthi tirkarthi reopened this

May 19, 2019

@tirkarthi

Copy link Copy Markdown

Member Author

@serhiy-storchaka @orsenthil @alex Would be helpful to have your review of this security backport to 2.7 branch.

@alex alex changed the title [2.7] bpo-35121: prefix dot in domain for proper subdomain validation [2.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258)

Jun 15, 2019

@bedevere-bot bedevere-bot added the type-security

A security issue

label

Jun 15, 2019

@tirkarthi

Copy link Copy Markdown

Member Author

Thank you @alex :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex alex alex approved these changes

Assignees

No one assigned

Labels

type-security

A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tirkarthi @alex @the-knights-who-say-ni @bedevere-bot @miss-islington