[3.6] bpo-31106: Fix handling of erros in posix_fallocate() and posix… by larryhastings · Pull Request #3088 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
[3.6] bpo-31106: Fix handling of erros in posix_fallocate() and posix…#3088
larryhastings wants to merge 1 commit into3.6from
[3.6] bpo-31106: Fix handling of erros in posix_fallocate() and posix…#3088
larryhastings wants to merge 1 commit into3.6from
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting merge
label
larryhastings
requested a review
from serhiy-storchaka
serhiy-storchaka approved these changes Aug 14, 2017
Copy link Copy Markdown
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the code is not different in 3.6 and master. Such kind of backports doesn't need a special review.
Copy link Copy Markdown
Member
serhiy-storchaka
commented
Aug 14, 2017
serhiy-storchaka commented
Aug 14, 2017I just wondering why the commit message contains doubled "(GH-3000)".
And both changes need NEWS entries. But it may be easier to add them by separate commits.
benjaminp
closed this
benjaminp
deleted the
backport-d4b93e2-3.6
branch
Copy link Copy Markdown
Contributor
benjaminp
commented
Sep 28, 2017
benjaminp commented
Sep 28, 2017I deleted the backport branch because it seemed old. Feel free to restore if this still needs to happen.
Mariatta
removed
the
awaiting merge
label
Copy link Copy Markdown
Contributor
What can I do in order to merge this branch to Python 3.6 ?
Does it differ from #4101 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants