[3.6] bpo-31106: Fix handling of erros in posix_fallocate() and posix_fadvise() (GH-3000) (GH-3000) by miss-islington · Pull Request #4101 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
asvetlov merged 1 commit intopython:3.6from
Feb 1, 2018Conversation
…se() (pythonGH-3000) (pythonGH-3000) (cherry picked from commit d4b93e2)
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Oct 24, 2017
miss-islington commented
Oct 24, 2017@socketpair and @larryhastings: Backport status check is done, and it's a failure ❌ .
1 similar comment
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Oct 24, 2017
miss-islington commented
Oct 24, 2017@socketpair and @larryhastings: Backport status check is done, and it's a failure ❌ .
Copy link Copy Markdown
Contributor
socketpair
commented
Oct 24, 2017
socketpair commented
Oct 24, 2017Well, what should I do ? I have no access to this branch.
Mariatta
added
the
skip news
label
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Oct 24, 2017
miss-islington commented
Oct 24, 2017@socketpair and @larryhastings: Backport status check is done, and it's a success ✅ .
Copy link Copy Markdown
Member
Mariatta
commented
Oct 24, 2017
Mariatta commented
Oct 24, 2017I just saw the comment in the bpo, seems like a news entry is needed.
I'll remove the skip news label. @socketpair, can you create a new backport PR that includes the news entry? I can then close this PR.
Mariatta
removed
the
skip news
label
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Oct 24, 2017
miss-islington commented
Oct 24, 2017@socketpair and @larryhastings: Backport status check is done, and it's a failure ❌ .
Copy link Copy Markdown
Contributor
socketpair
commented
Dec 23, 2017
socketpair commented
Dec 23, 2017What can I do in order to merge this branch to Python 3.6 ?
socketpair
mentioned this pull request
Copy link Copy Markdown
Member
Mariatta
commented
Dec 26, 2017
Mariatta commented
Dec 26, 2017@socketpair Please create your own backport PR and add the news entry there..
Copy link Copy Markdown
Contributor
asvetlov
commented
Jan 31, 2018
asvetlov commented
Jan 31, 2018Original PR was merged without NEWS, let's add the record in separate PR
asvetlov
added
the
skip news
label
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Jan 31, 2018
miss-islington commented
Jan 31, 2018@socketpair and @larryhastings: Backport status check is done, and it's a success ✅ .
asvetlov
merged commit
3a04c52
into
python:3.6
Copy link Copy Markdown
bedevere-bot
commented
Feb 1, 2018
bedevere-bot commented
Feb 1, 2018@asvetlov: Please replace # with GH- in the commit message next time. Thanks!
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Feb 1, 2018
miss-islington commented
Feb 1, 2018Thanks, @asvetlov!
bedevere-bot
removed
the
awaiting review
label
miss-islington
deleted the
backport-d4b93e2-3.6
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment