[3.7] bpo-32303 - Consistency fixes for namespace loaders (GH-5481) by miss-islington · Pull Request #5498 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Closed
miss-islington wants to merge 1 commit intopython:3.7from
Closed
[3.7] bpo-32303 - Consistency fixes for namespace loaders (GH-5481)#5498
miss-islington wants to merge 1 commit intopython:3.7from
[3.7] bpo-32303 - Consistency fixes for namespace loaders (GH-5481)#5498
miss-islington wants to merge 1 commit intopython:3.7from
Conversation
Copy link Copy Markdown
Contributor
- Make sure
__spec__.loadermatches__loader__for namespace packages. - Make sure
__spec__.origin` matchesfile`` for namespace packages.
https://bugs.python.org/issue32303
https://bugs.python.org/issue32305
(cherry picked from commit bbbcf86)
Co-authored-by: Barry Warsaw barry@python.org
* Make sure ``__spec__.loader`` matches ``__loader__`` for namespace packages. * Make sure ``__spec__.origin` matches ``__file__`` for namespace packages. https://bugs.python.org/issue32303 https://bugs.python.org/issue32305 (cherry picked from commit bbbcf86) Co-authored-by: Barry Warsaw <barry@python.org>
bedevere-bot
mentioned this pull request
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Feb 2, 2018
miss-islington commented
Feb 2, 2018@warsaw: Backport status check is done, and it's a success ✅ .
1 similar comment
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Feb 2, 2018
miss-islington commented
Feb 2, 2018@warsaw: Backport status check is done, and it's a success ✅ .
warsaw
mentioned this pull request
Copy link Copy Markdown
Member
warsaw
commented
Feb 2, 2018
warsaw commented
Feb 2, 2018Closing in favor of #5503 - @brettcannon and I agree that because of the changes to importlib.h and importlib_external.h, it's safer to do a manual rebuild and merge.
warsaw
closed this
miss-islington
deleted the
backport-bbbcf86-3.7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment