Miss islington backport bbbcf86 3.7 by warsaw · Pull Request #5503 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@warsaw

Copy link Copy Markdown

Member

@warsaw warsaw commented

Feb 2, 2018

A manual backport is safer than #5498 because of the changes to importlib.h and importlib_external.h.

* Make sure ``__spec__.loader`` matches ``__loader__`` for namespace packages.
* Make sure ``__spec__.origin` matches ``__file__`` for namespace packages.

https://bugs.python.org/issue32303
https://bugs.python.org/issue32305
(cherry picked from commit bbbcf86)

Co-authored-by: Barry Warsaw <barry@python.org>

@bedevere-bot

Copy link Copy Markdown

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

@warsaw warsaw deleted the miss-islington-backport-bbbcf86-3.7 branch

February 3, 2018 00:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@warsaw @bedevere-bot @the-knights-who-say-ni