Home Original page

Keyword argument checking by murrayrm · Pull Request #713 · python-control/python-control

Conversation

@murrayrm

This PR implements checks for unrecognized keywords in all functions that accept variable keywords (addressing #528). This is accomplished using a the kwargs_test unit test, which inspects the module, finds all functions with variable keyword arguments, and then makes sure there is a unit test that confirms that sending an unknown keyword generates an error.

@murrayrm murrayrm linked an issue

Mar 23, 2022

that may be closed by this pull request

@coveralls

Coverage Status

Coverage increased (+0.8%) to 94.34% when pulling 87cb31a on murrayrm:kwargs_20Mar2022 into cfe21de on python-control:master.

@murrayrm murrayrm marked this pull request as ready for review

March 30, 2022 05:36

@murrayrm

Rebased and changed from draft to ready to merge. While improvements are possible, this has already caught several bugs (eg, commit 3656968, issue #702) and so I think it is OK to merge in.