Pin to Python 3.9.16-1 by radarhere · Pull Request #7762 · python-pillow/Pillow
Conversation
Copy link Copy Markdown
Member
radarhere
commented
Jan 30, 2024
radarhere
commented
Our Cygwin jobs have been failing for several days - https://github.com/python-pillow/Pillow/actions/workflows/test-cygwin.yml
In looking at a discussion over at NumPy about this, there was a suggestion to use the egor-tension/setup-cygwin action and pin to Python 3.9.16-1 - numpy/numpy#25708 (comment)
radarhere
added
the
Testing
label
Copy link Copy Markdown
Member
hugovk
commented
Jan 30, 2024
hugovk commented
Jan 30, 2024Sounds like a good idea. Has this been reported upstream to Cygwin?
Copy link Copy Markdown
Member Author
radarhere
commented
Jan 30, 2024
radarhere commented
Jan 30, 2024I've just posted in the Cygwin mailing list - https://cygwin.com/pipermail/cygwin/2024-January/255273.html
Copy link Copy Markdown
Member
hugovk
commented
Jan 30, 2024
hugovk commented
Jan 30, 2024So before, both 3.8 and 3.9 jobs were timing out: https://github.com/python-pillow/Pillow/actions/runs/7705171752
Now, we've switched to egor-tensin/setup-cygwin but does python39=3.9.16-1 mean we install that for both 3.8 and 3.9 jobs? But we're still testing with either 3.8 or 3.9 for the relevant job.
https://github.com/python-pillow/Pillow/actions/runs/7708554081
Copy link Copy Markdown
Member Author
radarhere
commented
Jan 30, 2024
radarhere commented
Jan 30, 2024python39 is already being installed in the 3.8 job, as some sort of dependency - https://github.com/python-pillow/Pillow/actions/runs/7705171752/job/20998682687#step:4:362. It's just explicit rather than implicit now so that the version can be pinned.
hugovk approved these changes Jan 30, 2024
EliahKagan
mentioned this pull request
hugovk
merged commit
db43738
into
python-pillow:main
radarhere
deleted the
cygwin
branch
EliahKagan
mentioned this pull request
radarhere
mentioned this pull request
radarhere
mentioned this pull request
Copy link Copy Markdown
Member Author
radarhere
commented
Mar 15, 2024
radarhere commented
Mar 15, 2024This was reverted in #7880
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment