Removed Python and NumPy pinning on Cygwin by radarhere · Pull Request #7880 · python-pillow/Pillow
Navigation Menu
{{ message }}
python-pillow / Pillow Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
Removed Python and NumPy pinning on Cygwin#7880
hugovk merged 2 commits intopython-pillow:mainfrom
Removed Python and NumPy pinning on Cygwin#7880
hugovk merged 2 commits intopython-pillow:mainfrom
Conversation
Copy link Copy Markdown
Member
Alternative to #7875
Two Cygwin changes
- Reverts Pin to Python 3.9.16-1 #7762, where Python was pinned to Python 3.9.16-1
- Removes the pinning of NumPy from NumPy now supports Python 3.12 #7403, but also goes further, and just uses the packaged NumPy. NumPy was originally upgraded in a commit entitled "CI: Try to get Cygwin workflow working.", so if there wasn't another need for this, then perhaps testing the package version is more valuable?
radarhere added 2 commits
March 14, 2024 23:05This reverts commit 139320b.
radarhere
added
the
NumPy
label
radarhere
mentioned this pull request
Copy link Copy Markdown
Contributor
DWesl
commented
Mar 15, 2024
DWesl commented
Mar 15, 2024Tests pass, and include NumPy. I think 1.21 had problems with unaligned load, but that seems gone now.
hugovk approved these changes Mar 15, 2024
src/PIL/Image.py
Show resolved
Hide resolved
src/PIL/Image.py Show resolved Hide resolved
hugovk
merged commit
786ded0
into
python-pillow:main
radarhere
deleted the
cygwin
branch
This was referenced
Mar 15, 2024Merged
data-sync-user
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment