feat: speed up ServiceInfo with a cython pxd by bdraco · Pull Request #1264 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
feat: speed up ServiceInfo with a cython pxd#1264
feat: speed up ServiceInfo with a cython pxd#1264
Conversation
Copy link Copy Markdown
Member
Its a shame that dns_text, dns_pointer etc take kwargs as we could make them cdefs as they are really what gets called the most here when using Homekit. We could change the function signatures but I've already found code in the while calling it so it would be a breaking change for them.
Copy link Copy Markdown
Codecov Report
Patch coverage is 100.00% of modified lines.
| Files Changed | Coverage |
|---|---|
| src/zeroconf/__init__.py | 100.00% |
| src/zeroconf/_engine.py | 100.00% |
| src/zeroconf/_handlers/record_manager.py | 100.00% |
| src/zeroconf/_record_update.py | 100.00% |
| src/zeroconf/_services/browser.py | 100.00% |
| src/zeroconf/_services/info.py | 100.00% |
| src/zeroconf/_updates.py | 100.00% |
📢 Thoughts on this report? Let us know!.
bdraco added 5 commits
September 10, 2023 17:41
bdraco
marked this pull request as ready for review
bdraco
merged commit
7ca690a
into
master
bdraco
deleted the
cython_service_info
branch
bdraco
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant