Home Original page

fix: re-expose ServiceInfo._set_properties for backwards compat by bdraco · Pull Request #1327 · python-zeroconf/python-zeroconf

Conversation

@bdraco

aiohomekit and others use this for testing so we need to make it a cpdef

This method was hidden from the python interface in #1264

aiohomekit and others use this for testing so we need
to make it a cpdef

@bdraco bdraco changed the title fix: make _set_properties a cpdef for backwards compat fix: re-expose ServiceInfo._set_properties for backwards compat

Dec 10, 2023

This was referenced

Dec 10, 2023

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd7a16a) 99.77% compared to head (7bf6cdf) 99.77%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          29       29           
  Lines        3106     3106           
  Branches      522      520    -2     
=======================================
  Hits         3099     3099           
  Misses          5        5           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco deleted the _set_properties branch

December 10, 2023 23:31

1 participant

@bdraco