feat: speed up record updates by bdraco · Pull Request #1301 · python-zeroconf/python-zeroconf

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

Conversation

@bdraco

Copy link Copy Markdown

Member

@bdraco bdraco commented

Nov 8, 2023

edited

Loading

  • adds more cython types
  • convert RecordUpdate to a base class since NamedTuple has the unfortunate side effect of running a lambda on creation which can't be optimized away

@codecov

Copy link Copy Markdown

codecov bot commented

Nov 8, 2023

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_handlers/query_handler.py 100.00% <100.00%> (ø)
src/zeroconf/_record_update.py 100.00% <100.00%> (ø)
src/zeroconf/_services/browser.py 99.23% <100.00%> (+<0.01%) ⬆️
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)
src/zeroconf/_updates.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@bdraco bdraco marked this pull request as ready for review

November 8, 2023 14:30

@bdraco bdraco merged commit d2af6a0 into master

Nov 8, 2023

@bdraco bdraco deleted the record_update branch

November 8, 2023 14:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdraco