fix: ensure question history suppresses duplicates by bdraco · Pull Request #1338 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
fix: ensure question history suppresses duplicates#1338
fix: ensure question history suppresses duplicates#1338
Conversation
Copy link Copy Markdown
Member
bdraco
commented
Dec 15, 2023
bdraco
commented
There was a bug in the cython conversion logic that would loose precision on the float to double conversion
There was a bug in the cython conversion logic that would loose precision on the float to double conversion
bdraco
changed the title
fix: ensure question history suppresses duplicates within 999ms
fix: ensure question history suppresses duplicates
Copy link Copy Markdown
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
9b595a1) 99.77% compared to head (97de9b6) 99.71%.
Report is 7 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1338 +/- ## ========================================== - Coverage 99.77% 99.71% -0.07% ========================================== Files 30 30 Lines 3164 3164 Branches 528 526 -2 ========================================== - Hits 3157 3155 -2 - Misses 5 7 +2 Partials 2 2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
bdraco
marked this pull request as ready for review
bdraco
merged commit
6f23656
into
master
bdraco
deleted the
fix_history_conversion_loss
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant