Translating "nav.yml" to Korean by rkdmf1026 · Pull Request #189 · reactjs/ko.react.dev
Copy link
Contributor
Progress
- 번역 초안 작성 (Draft translation)
- 공통 스타일 가이드 확인 (Check the common style guide)
- 모범사례 확인 (Check best practices)
- 용어 확인 (Check the term)
- 맞춤법 검사 (Spelling check)
- 리뷰 반영 (Resolve reviews)
Copy link
Deploy preview for ko-reactjs-org ready!
Built with commit d06491e
gnujoow previously approved these changes Nov 19, 2019
Copy link
Member
gnujoow
left a comment
gnujoow
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
현재 번역이 진행중인 문서도 있는것 같아 해당 문서와 nav.yml의 제목이 일치하는지 한번 확인해주시면 감사하겠습니다.
todo
- 새로 추가된 문서의 제목과 nav.yml의 제목 일치 확인
hg-pyun
added
the
needs review
label
rkdmf1026
dismissed
gnujoow’s stale review
via
6d0445f
Copy link
Contributor Author
rkdmf1026
commented
Nov 20, 2019
rkdmf1026 commented
Nov 20, 2019taehwanno requested changes Nov 20, 2019
content/docs/nav.yml
Outdated
Show resolved
Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
taehwanno
added
needs author response
and removed
needs review
labels
rkdmf1026 and others added 2 commits
November 21, 2019 20:41taehwanno previously approved these changes Nov 21, 2019
Copy link
Member
taehwanno
left a comment
taehwanno
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
공백 하나 직접 추가했습니다. 고생하셨습니다 ㅎㅎ
taehwanno
added
needs +1 approval
and removed
needs author response
labels
taehwanno
dismissed
their stale review
via
825ad70
Copy link
Member
taehwanno
commented
Nov 21, 2019
taehwanno commented
Nov 21, 2019API Reference가 API 참고서로 번역되어 있어서 통일시키기 위해 추가 커밋했습니다.
taehwanno approved these changes Nov 21, 2019
taehwanno
mentioned this pull request
6 tasks
gnujoow approved these changes Nov 22, 2019
gnujoow
added
ready to merge
and removed
needs +1 approval
labels
hg-pyun approved these changes Nov 22, 2019
Copy link
Member
hg-pyun
left a comment
hg-pyun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
taehwanno
merged commit
fad39de
into
reactjs:master
tesseralis
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters