coverage: Split out counter increment sites from BCB node/edge counters by Zalathar · Pull Request #120564

coverage: Split out counter increment sites from BCB node/edge counters by Zalathar · Pull Request #120564 · rust-lang/rust

This makes it possible for two nodes/edges in the coverage graph to share the
same counter, without causing the instrumentor to inject unwanted duplicate
counter-increment statements.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 2, 2024

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 6, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 6, 2024

coverage: Split out counter increment sites from BCB node/edge counters

This makes it possible for two nodes/edges in the coverage graph to share the same counter, without causing the instrumentor to inject unwanted duplicate counter-increment statements.

---

`@rustbot` label +A-code-coverage

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 6, 2024

coverage: Split out counter increment sites from BCB node/edge counters

This makes it possible for two nodes/edges in the coverage graph to share the same counter, without causing the instrumentor to inject unwanted duplicate counter-increment statements.

---

``@rustbot`` label +A-code-coverage

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 6, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120302 (various const interning cleanups)
 - rust-lang#120520 (Some cleanups around diagnostic levels.)
 - rust-lang#120521 (Make `NonZero` constructors generic.)
 - rust-lang#120527 (Switch OwnedStore handle count to AtomicU32)
 - rust-lang#120564 (coverage: Split out counter increment sites from BCB node/edge counters)
 - rust-lang#120575 (Simplify codegen diagnostic handling)
 - rust-lang#120597 (Suggest `[tail @ ..]` on `[..tail]` and `[...tail]` where `tail` is unresolved)
 - rust-lang#120609 (hir: Stop keeping prefixes for most of `use` list stems)
 - rust-lang#120633 (pattern_analysis: gather up place-relevant info)

r? `@ghost`
`@rustbot` modify labels: rollup

Nadrieril added a commit to Nadrieril/rust that referenced this pull request

Feb 7, 2024

coverage: Split out counter increment sites from BCB node/edge counters

This makes it possible for two nodes/edges in the coverage graph to share the same counter, without causing the instrumentor to inject unwanted duplicate counter-increment statements.

---

```@rustbot``` label +A-code-coverage

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 7, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 7, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 7, 2024

Rollup merge of rust-lang#120564 - Zalathar:increment-site, r=oli-obk

coverage: Split out counter increment sites from BCB node/edge counters

This makes it possible for two nodes/edges in the coverage graph to share the same counter, without causing the instrumentor to inject unwanted duplicate counter-increment statements.

---

````@rustbot```` label +A-code-coverage