Use `eprintln` instead of `println` in bootstrap/compiletest/tidy by clubby789 · Pull Request #133817 · rust-lang/rust
rustbot
added
A-compiletest
labels
Dec 3, 2024
rustbot
added
S-waiting-on-author
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
Dec 3, 2024
clubby789
added
S-waiting-on-review
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.labels
Dec 4, 2024
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
Dec 4, 2024bors added a commit to rust-lang-ci/rust that referenced this pull request
Dec 4, 2024…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#133651 (Update `NonZero` and `NonNull` to not field-project (per MCP#807)) - rust-lang#133764 (rustdoc: Rename `set_back_info` to `restore_module_data`.) - rust-lang#133784 (Fix MutVisitor's default implementations to visit Stmt's and BinOp's spans) - rust-lang#133798 (stop replacing bivariant args with `'static` when computing closure requirements) - rust-lang#133804 (Improve code for FileName retrieval in rustdoc) - rust-lang#133817 (Use `eprintln` instead of `println` in bootstrap/compiletest/tidy) Failed merges: - rust-lang#133810 (remove unnecessary `eval_verify_bound`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Dec 4, 2024Rollup merge of rust-lang#133817 - clubby789:bootstrap-eprintln, r=jieyouxu Use `eprintln` instead of `println` in bootstrap/compiletest/tidy A big unconditional CTRL-F replace to start with to check if there's anything that CI expects to be on stdout r? `@jieyouxu`
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
Dec 5, 2024…ln, r=jieyouxu" This reverts commit 0585134, reversing changes made to 5530869. The PR unfortunately only converted the `ln!` instances, meaning that test output was messed up because stdout/stderr output interleaved when some `println!` instances were converted to `eprintln!` instances, while some `println!` instances remain unchanged.
Zalathar added a commit to Zalathar/rust that referenced this pull request
Dec 5, 2024fmease added a commit to fmease/rust that referenced this pull request
Dec 5, 2024Revert rust-lang#133817 This reverts commit 0585134, reversing changes made to 5530869. rust-lang#133817 unfortunately only converted the `println!` instances to `eprintln!`, meaning that some test output (via compiletest/bootstrap) was messed up because stdout/stderr output interleaved improperly when some `println!` instances were converted to `eprintln!` instances, while some `print!` instances remain unchanged. This made reading test output annoying for contributors cc rust-lang#133879. Closes rust-lang#133879 by reverting. rust-lang#133817 can be relanded in the future when `print!` instances are also matched with `println!` instances. cc `@clubby789` This is a clean revert so I'm going to self-approve this PR.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Dec 5, 2024Rollup merge of rust-lang#133892 - jieyouxu:revert-eprintln, r=jieyouxu Revert rust-lang#133817 This reverts commit 0585134, reversing changes made to 5530869. rust-lang#133817 unfortunately only converted the `println!` instances to `eprintln!`, meaning that some test output (via compiletest/bootstrap) was messed up because stdout/stderr output interleaved improperly when some `println!` instances were converted to `eprintln!` instances, while some `print!` instances remain unchanged. This made reading test output annoying for contributors cc rust-lang#133879. Closes rust-lang#133879 by reverting. rust-lang#133817 can be relanded in the future when `print!` instances are also matched with `println!` instances. cc `@clubby789` This is a clean revert so I'm going to self-approve this PR.
fmease added a commit to fmease/rust that referenced this pull request
Dec 9, 2024…eyouxu
bootstrap: print{ln}! -> eprint{ln}! (take 2)
r? `@jieyouxu`
Reland of rust-lang#133817 with the `print!`s changed as well.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Dec 10, 2024Rollup merge of rust-lang#134040 - clubby789:bootstrap-eprintln, r=jieyouxu bootstrap: print{ln}! -> eprint{ln}! (take 2) r? `@jieyouxu` Reland of rust-lang#133817 with the `print!`s changed as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters