bootstrap: print{ln}! -> eprint{ln}! (take 2) by clubby789 · Pull Request #134040 · rust-lang/rust
rustbot
added
A-compiletest
labels
Dec 8, 2024
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
Dec 9, 2024bors added a commit to rust-lang-ci/rust that referenced this pull request
Dec 10, 2024Rollup of 9 pull requests Successful merges: - rust-lang#133996 (Move most tests for `-l` and `#[link(..)]` into `tests/ui/link-native-libs`) - rust-lang#134012 (Grammar fixes) - rust-lang#134032 (docs: better examples for `std::ops::ControlFlow`) - rust-lang#134040 (bootstrap: print{ln}! -> eprint{ln}! (take 2)) - rust-lang#134043 (Add test to check unicode identifier version) - rust-lang#134053 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)) - rust-lang#134055 (interpret: clean up deduplicating allocation functions) - rust-lang#134073 (dataflow_const_prop: do not eval a ptr address in SwitchInt) - rust-lang#134084 (Fix typo in RFC mention 3598 -> 3593) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Dec 10, 2024Rollup merge of rust-lang#134040 - clubby789:bootstrap-eprintln, r=jieyouxu bootstrap: print{ln}! -> eprint{ln}! (take 2) r? `@jieyouxu` Reland of rust-lang#133817 with the `print!`s changed as well.
fmease added a commit to fmease/rust that referenced this pull request
Dec 10, 2024…lubby789 bootstrap: Forward cargo JSON output to stdout, not stderr This fixes the RA errors I've been seeing on proc-macros after the re-landing of rust-lang#134040. r? clubby789
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Dec 10, 2024Rollup merge of rust-lang#134123 - Zalathar:json-output, r=jieyouxu,clubby789 bootstrap: Forward cargo JSON output to stdout, not stderr This fixes the RA errors I've been seeing on proc-macros after the re-landing of rust-lang#134040. r? clubby789
This was referenced
Dec 12, 2024jieyouxu added a commit to jieyouxu/rust that referenced this pull request
Dec 12, 2024bors added a commit to rust-lang-ci/rust that referenced this pull request
Dec 12, 2024Revert "bootstrap: print{ln}! -> eprint{ln}! (take 2) rust-lang#134040"
Unfortunately, rust-lang#134040 is proving to have caused more output interleaving problems that are tricky to diagnose and fix, and I think we probably should leave these untouched as bootstrap and compiletest has a bunch of interconnecting parts, and the commands and tools that they exercise do not consistently use stderr/stdout either. This causes hard-to-diagnose output interleaving bugs, which unfortunately degrades contributor experience.
This PR reverts two PRs in order to cleanly revert rust-lang#134040:
1. Revert rust-lang#134123 which is a fix-forward after rust-lang#134040.
2. Revert rust-lang#134040 itself.
I don't regret the initial effort `@clubby789,` and thank you for making the attempts, but I think we need to refrain from touching too many of these at once because some of the interleaving are very non-obvious and we don't have test coverage for.
r? `@clubby789`
cc `@Zalathar`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Dec 12, 2024Revert "bootstrap: print{ln}! -> eprint{ln}! (take 2) rust-lang#134040"
Unfortunately, rust-lang#134040 is proving to have caused more output interleaving problems that are tricky to diagnose and fix, and I think we probably should leave these untouched as bootstrap and compiletest has a bunch of interconnecting parts, and the commands and tools that they exercise do not consistently use stderr/stdout either. This causes hard-to-diagnose output interleaving bugs, which unfortunately degrades contributor experience.
This PR reverts two PRs in order to cleanly revert rust-lang#134040:
1. Revert rust-lang#134123 which is a fix-forward after rust-lang#134040.
2. Revert rust-lang#134040 itself.
I don't regret the initial effort `@clubby789,` and thank you for making the attempts, but I think we need to refrain from touching too many of these at once because some of the interleaving are very non-obvious and we don't have test coverage for.
r? `@clubby789`
cc `@Zalathar`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Dec 12, 2024Rollup merge of rust-lang#134207 - jieyouxu:revert-134040, r=lqd Revert "bootstrap: print{ln}! -> eprint{ln}! (take 2) rust-lang#134040" Unfortunately, rust-lang#134040 is proving to have caused more output interleaving problems that are tricky to diagnose and fix, and I think we probably should leave these untouched as bootstrap and compiletest has a bunch of interconnecting parts, and the commands and tools that they exercise do not consistently use stderr/stdout either. This causes hard-to-diagnose output interleaving bugs, which unfortunately degrades contributor experience. This PR reverts two PRs in order to cleanly revert rust-lang#134040: 1. Revert rust-lang#134123 which is a fix-forward after rust-lang#134040. 2. Revert rust-lang#134040 itself. I don't regret the initial effort `@clubby789,` and thank you for making the attempts, but I think we need to refrain from touching too many of these at once because some of the interleaving are very non-obvious and we don't have test coverage for. r? `@clubby789` cc `@Zalathar`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters