Home Original page

Couple of cleanups to DiagCtxt and EarlyDiagCtxt by bjorn3 · Pull Request #136445 · rust-lang/rust

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Feb 2, 2025 
All callers of EarlyDiagCtxt::early_error now emit a fatal error.

@bjorn3

@bjorn3

@bjorn3 

Replacing the error emitter doesn't accidentally clear the error count.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 2, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136145 (Test validity of pattern types)
 - rust-lang#136339 (CompileTest: Add Directives to Ignore `arm-unknown-*` Targets)
 - rust-lang#136403 (Fix malformed error annotations in a UI test)
 - rust-lang#136414 (Shorten error message for callable with wrong return type)
 - rust-lang#136425 (Move `rustc_middle::infer::unify_key`)
 - rust-lang#136426 (Explain why we retroactively change a static initializer to have a different type)
 - rust-lang#136445 (Couple of cleanups to DiagCtxt and EarlyDiagCtxt)
 - rust-lang#136452 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 2, 2025 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136145 (Test validity of pattern types)
 - rust-lang#136339 (CompileTest: Add Directives to Ignore `arm-unknown-*` Targets)
 - rust-lang#136403 (Fix malformed error annotations in a UI test)
 - rust-lang#136414 (Shorten error message for callable with wrong return type)
 - rust-lang#136425 (Move `rustc_middle::infer::unify_key`)
 - rust-lang#136426 (Explain why we retroactively change a static initializer to have a different type)
 - rust-lang#136445 (Couple of cleanups to DiagCtxt and EarlyDiagCtxt)
 - rust-lang#136452 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 3, 2025 
Rollup merge of rust-lang#136445 - bjorn3:diag_ctxt_cleanup, r=oli-obk

Couple of cleanups to DiagCtxt and EarlyDiagCtxt

@bjorn3 bjorn3 deleted the diag_ctxt_cleanup branch

February 3, 2025 10:07

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Feb 6, 2025 
Couple of cleanups to DiagCtxt and EarlyDiagCtxt

jyn514