editorconfig: don't use nonexistent syntax by lolbinarycat · Pull Request #145823 · rust-lang/rust

@lolbinarycat

reading through the editorconfig spec, using `!` to negate
an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not
what was going on here.

@rustbot rustbot added A-meta

Area: Issues & PRs about the rust-lang/rust repository itself

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 24, 2025

@joshtriplett joshtriplett changed the title editorconfig: don't use nonexistant syntax editorconfig: don't use nonexistent syntax

Aug 24, 2025

GuillaumeGomez

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 2, 2025

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Sep 2, 2025
…uillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Sep 2, 2025
…uillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.

bors added a commit that referenced this pull request

Sep 2, 2025
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145962 (Ensure we emit an allocator shim when only some crate types need one)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146090 (Derive `PartialEq` for `InvisibleOrigin`)
 - #146120 (Correct typo in `rustc_errors` comment)
 - #146121 (fix: Filter suggestion parts that match existing code)
 - #146134 (llvm: nvptx: Layout update to match LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup

tgross35 added a commit to tgross35/rust that referenced this pull request

Sep 3, 2025
…uillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.

bors added a commit that referenced this pull request

Sep 3, 2025
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request

Sep 3, 2025
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )

r? `@ghost`
`@rustbot` modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request

Sep 3, 2025
…uillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.

bors added a commit that referenced this pull request

Sep 3, 2025
Rollup of 9 pull requests

Successful merges:

 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )
 - #146112 (don't uppercase error messages)
 - #146154 (CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request

Sep 3, 2025
Rollup of 8 pull requests

Successful merges:

 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )
 - #146154 (CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit that referenced this pull request

Sep 3, 2025
Rollup merge of #145823 - lolbinarycat:editorconfig-fix, r=GuillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.