fix: Filter suggestion parts that match existing code by Muscraft · Pull Request #146121 · rust-lang/rust

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-clippy

Relevant to the Clippy team.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Sep 2, 2025

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 2, 2025

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Sep 2, 2025

bors added a commit that referenced this pull request

Sep 2, 2025
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145962 (Ensure we emit an allocator shim when only some crate types need one)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146090 (Derive `PartialEq` for `InvisibleOrigin`)
 - #146120 (Correct typo in `rustc_errors` comment)
 - #146121 (fix: Filter suggestion parts that match existing code)
 - #146134 (llvm: nvptx: Layout update to match LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup

tgross35 added a commit to tgross35/rust that referenced this pull request

Sep 3, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request

Sep 3, 2025

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Sep 3, 2025

rust-bors bot added a commit that referenced this pull request

Sep 3, 2025
fix: Filter suggestion parts that match existing code

try-job: aarch64-apple

rust-bors bot added a commit that referenced this pull request

Sep 3, 2025
fix: Filter suggestion parts that match existing code

try-job: aarch64-apple

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 5, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2025

bors added a commit that referenced this pull request

Sep 5, 2025
Rollup of 4 pull requests

Successful merges:

 - #138944 (Add `__isPlatformVersionAtLeast` and `__isOSVersionAtLeast` symbols)
 - #146041 (tidy: --bless now makes escheck run with --fix)
 - #146121 (fix: Filter suggestion parts that match existing code)
 - #146241 (rustc_infer: change top-level doc comment to inner)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request

Sep 5, 2025
Rollup of 4 pull requests

Successful merges:

 - #138944 (Add `__isPlatformVersionAtLeast` and `__isOSVersionAtLeast` symbols)
 - #146041 (tidy: --bless now makes escheck run with --fix)
 - #146121 (fix: Filter suggestion parts that match existing code)
 - #146241 (rustc_infer: change top-level doc comment to inner)

r? `@ghost`
`@rustbot` modify labels: rollup

@Muscraft Muscraft deleted the filter-suggestion-parts branch

September 16, 2025 06:25

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Sep 18, 2025

This was referenced

Sep 19, 2025

Muscraft pushed a commit to Muscraft/rust that referenced this pull request

Sep 24, 2025

lqd added a commit to lqd/rust that referenced this pull request

Oct 23, 2025
…arts, r=petrochenkov"

This reverts commit 99317ef, reversing
changes made to 9cd272d.

@lqd lqd mentioned this pull request

Oct 23, 2025

lqd added a commit to lqd/rust that referenced this pull request

Oct 23, 2025
…arts, r=petrochenkov"

This reverts commit 99317ef, reversing
changes made to 9cd272d.

bors added a commit that referenced this pull request

Oct 24, 2025
Revert "fix: Filter suggestion parts that match existing code"

As requested by `@wesleywiser` in #147973 (comment) this is a revert of #146121 due to the handful of diagnostics ICEs that have been since reported, and found in the beta crater run.

This should thus also be backported to beta so the ICEs don't make it to next week's stable.

Works around (after backport)
- #146261
- #146706
- #146834 but I didn't add a test for this allowed-by-default lint
- as well as the crater run regressions from #147973 of which I only added the MCVE as a test.

The proper fix would likely be #147849 but it's still currently at the MCP stage. In the meantime, this PR would still emit the same overlapping suggestions, but still use a debug-assert...

r? `@wesleywiser`

bors added a commit that referenced this pull request

Oct 24, 2025
Revert "fix: Filter suggestion parts that match existing code"

As requested by `@wesleywiser` in #147973 (comment) this is a revert of #146121 due to the handful of diagnostics ICEs that have been since reported, and found in the beta crater run.

This should thus also be backported to beta so the ICEs don't make it to next week's stable.

Works around (after backport)
- #146261
- #146706
- #146834 but I didn't add a test for this allowed-by-default lint
- as well as the crater run regressions from #147973 of which I only added the MCVE as a test.

The proper fix would likely be #147849 but it's still currently at the MCP stage. In the meantime, this PR would still emit the same overlapping suggestions, but still use a debug-assert...

r? `@wesleywiser`

cuviper pushed a commit to cuviper/rust that referenced this pull request

Oct 24, 2025
…arts, r=petrochenkov"

This reverts commit 99317ef, reversing
changes made to 9cd272d.

(cherry picked from commit a2b4833)

flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request

Oct 27, 2025
Revert "fix: Filter suggestion parts that match existing code"

As requested by `@wesleywiser` in rust-lang/rust#147973 (comment) this is a revert of rust-lang/rust#146121 due to the handful of diagnostics ICEs that have been since reported, and found in the beta crater run.

This should thus also be backported to beta so the ICEs don't make it to next week's stable.

Works around (after backport)
- rust-lang/rust#146261
- rust-lang/rust#146706
- rust-lang/rust#146834 but I didn't add a test for this allowed-by-default lint
- as well as the crater run regressions from rust-lang/rust#147973 of which I only added the MCVE as a test.

The proper fix would likely be rust-lang/rust#147849 but it's still currently at the MCP stage. In the meantime, this PR would still emit the same overlapping suggestions, but still use a debug-assert...

r? `@wesleywiser`

Muscraft added a commit to Muscraft/rust that referenced this pull request

Oct 30, 2025

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Oct 31, 2025
…arts, r=petrochenkov"

This reverts commit 99317ef, reversing
changes made to 9cd272d.

arshadm pushed a commit to teenygrad/rustx that referenced this pull request

Dec 4, 2025
…arts, r=petrochenkov"

This reverts commit 99317ef, reversing
changes made to 9cd272d.

(cherry picked from commit a2b4833)