Do not ICE when we have `-Zunpretty=expanded` with invalid ABI by compiler-errors · Pull Request #99360

Do not ICE when we have `-Zunpretty=expanded` with invalid ABI by compiler-errors · Pull Request #99360 · rust-lang/rust

rustbot added the T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

label

Jul 17, 2022

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 17, 2022

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Jul 17, 2022

…-dead

Do not ICE when we have `-Zunpretty=expanded` with invalid ABI

Fixes rust-lang#99331

This was referenced

Jul 17, 2022

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 18, 2022

Rollup of 6 pull requests

Successful merges:

 - rust-lang#98383 (Remove restrictions on compare-exchange memory ordering.)
 - rust-lang#99350 (Be more precise when suggesting removal of parens on unit ctor)
 - rust-lang#99356 (Do not constraint TAITs when checking impl/trait item compatibility)
 - rust-lang#99360 (Do not ICE when we have `-Zunpretty=expanded` with invalid ABI)
 - rust-lang#99373 (Fix source code sidebar tree auto-expand)
 - rust-lang#99374 (Fix doc for `rchunks_exact`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 4, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 4, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

tgross35 added a commit to tgross35/rust that referenced this pull request

Mar 4, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Mar 4, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Mar 5, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

Rollup merge of rust-lang#137975 - Zalathar:needs-hir, r=compiler-errors

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.