Remove unused `PpMode::needs_hir` by Zalathar · Pull Request #137975

Remove unused `PpMode::needs_hir` by Zalathar · Pull Request #137975 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 4, 2025

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 4, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 4, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 4, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 4, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request

Mar 4, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 4, 2025

Rollup of 6 pull requests

Successful merges:

 - rust-lang#135695 (Support raw-dylib link kind on ELF)
 - rust-lang#137836 (Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl`)
 - rust-lang#137913 (Allow struct field default values to reference struct's generics)
 - rust-lang#137949 (Update MSVC INSTALL.md instructions to recommend VS 2022 + recent Windows 10/11 SDK)
 - rust-lang#137963 (Add ``dyn`` keyword to `E0373` examples)
 - rust-lang#137975 (Remove unused `PpMode::needs_hir`)

r? `@ghost`
`@rustbot` modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Mar 4, 2025

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

Rollup merge of rust-lang#137975 - Zalathar:needs-hir, r=compiler-errors

Remove unused `PpMode::needs_hir`

This method was added in rust-lang#99360 to avoid an overzealous `span_delayed_bug` ICE in specific circumstances, but the only caller was subsequently removed in rust-lang#136603, which presumably avoids the problem in a more principled way.

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Mar 14, 2025