Fix crash in tests: Use explicit RedisCommand instead of tuple by fabianfett · Pull Request #52 · swift-server/RediStack

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@fabianfett

Copy link Copy Markdown

Member

Motivation

Currently the RediStack tests crash for our new main branch. We should have working tests.

Changes

  • Use explicit RedisCommand instead of tuple

@fabianfett fabianfett changed the title Fix crash in 1.x tests Fix crash in tests: Use explicit RedisCommand instead of tuple

Jun 16, 2023

@fabianfett fabianfett mentioned this pull request

Jun 16, 2023

@fabianfett fabianfett added this to the Transfer milestone

Jun 16, 2023

@fabianfett fabianfett added the semver/none

No version bump required.

label

Jun 16, 2023
Respect `REDIS_URL` in all tests

@fabianfett fabianfett merged commit 35e0d67 into main

Jun 16, 2023

@fabianfett fabianfett deleted the ff-fix-1.x-tests branch

June 16, 2023 17:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Joannis Joannis Joannis approved these changes

Assignees

No one assigned

Labels

semver/none

No version bump required.

Projects

None yet

Milestone

Transfer ownership

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianfett @Joannis