Home Original page

Add swift-server CI by fabianfett · Pull Request #54 · swift-server/RediStack

Conversation

@fabianfett

Motivation

We want to use the swift-server CI going forward. For this we need to add a bunch of docker magic to work.

Changes

  • Add docker-compose files to run tests in swift-server ci

Open ends

Some of the CI jobs will fail. We should enable it and one by one make it green. First one is already posted: #52.

@Joannis

@yim-lee

@yim-lee

@Joannis CI should be triggered automatically once I set them up, or they can be force-triggered using "test this please" comment (e.g., #54 (comment))

@fabianfett

CI fails as expected. Will fix with follow up PR #52.

yim-lee

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI jobs are configured. We can add soundness check job etc. later when ready. Just let me know.

Comment on lines +31 to +34

ARG swiftformat_version=0.48.8
RUN git clone --branch $swiftformat_version --depth 1 https://github.com/nicklockwood/SwiftFormat $HOME/.tools/swift-format
RUN cd $HOME/.tools/swift-format && swift build -c release
RUN ln -s $HOME/.tools/swift-format/.build/release/swiftformat $HOME/.tools/swiftformat

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this block if there is no plan to run swiftformat.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to enable it very soon :)

Joannis

Labels