test(isRgbColor): fix test expectations by WikiRik · Pull Request #2538 · validatorjs/validator.js
Navigation Menu
{{ message }}
validatorjs / validator.js Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
test(isRgbColor): fix test expectations#2538
profnandaa merged 2 commits intomasterfrom
test(isRgbColor): fix test expectations#2538
profnandaa merged 2 commits intomasterfrom
Conversation
Copy link Copy Markdown
Member
WikiRik
commented
Mar 27, 2025
WikiRik
commented
Fixes the wrong test expectations for isRgbColor that occurred due to a former merge conflict. Also updates typo in package.json
Checklist
- PR contains only changes related; no stray files, etc.
- README updated (where applicable)
- Tests written (where applicable)
- References provided in PR (where applicable)
Also updates typo in package.json
WikiRik
requested review from
profnandaa and
rubiin
WikiRik
mentioned this pull request
4 tasks
Copy link Copy Markdown
Member Author
WikiRik
commented
Mar 27, 2025
WikiRik commented
Mar 27, 2025@rubiin @profnandaa sorry for the ping, but would be great if we could merge this PR soon so we can have tests passing on master again
sgress454
mentioned this pull request
2 tasks
vitorgamer58 approved these changes Apr 3, 2025
Copy link Copy Markdown
Member Author
WikiRik
commented
Apr 8, 2025
WikiRik commented
Apr 8, 2025@rubiin @profnandaa sorry for the ping, but would be great if we could merge this PR soon so we can have tests passing on
masteragain
@rubiin @profnandaa reminder for the above, tests are failing on master at this moment
profnandaa approved these changes Apr 8, 2025
WikiRik
deleted the
WikiRik/isRgbColor-tests
branch
WikiRik
mentioned this pull request
fossabot
bot
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants