Polish GradleExtension tests by Goooler · Pull Request #1908 · diffplug/spotless
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 513
Merged
nedtwigg merged 3 commits intodiffplug:mainfrom
Nov 27, 2023Merged
Polish GradleExtension tests#1908
nedtwigg merged 3 commits intodiffplug:mainfrom
Polish GradleExtension tests#1908
nedtwigg merged 3 commits intodiffplug:mainfrom
Conversation
Copy link Copy Markdown
Member
Changed:
- Remove redundant tests in
GroovyGradleExtensionTest, and let it extendGroovyExtensionTest. - Remove redundant tests in
KotlinGradleExtensionTest, and let it extendKotlinExtensionTest. - Bump Kotlin plugins for Java 21 tests in the future.
Follow up:
Goooler added 2 commits
November 26, 2023 17:34
Goooler
force-pushed
the
bump-kt-plugin-in-tests
branch
from
8d32b45 to
4775485
Compare
We can't use the latest version, due to the Gradle matrix limit in tests.
Goooler commented Nov 26, 2023
| setFile("build.gradle").toLines( | ||
| "plugins {", | ||
| " id 'org.jetbrains.kotlin.jvm' version '1.5.31'", | ||
| " id 'org.jetbrains.kotlin.jvm' version '1.6.21'", |
Copy link Copy Markdown
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump this for #1907, can't use newer Kotlin versions due to the limit of Gradle matrix.
nedtwigg
merged commit
c4f8a88
into
diffplug:main
Goooler
deleted the
bump-kt-plugin-in-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants