Update mjcf schema by hartikainen · Pull Request #380 · google-deepmind/dm_control
Navigation Menu
{{ message }}
google-deepmind / dm_control Public
- Notifications You must be signed in to change notification settings
- Fork 745
Open
hartikainen wants to merge 4 commits intogoogle-deepmind:mainfrom
Open
hartikainen wants to merge 4 commits intogoogle-deepmind:mainfrom
hartikainen wants to merge 4 commits intogoogle-deepmind:mainfrom
Conversation
Copy link Copy Markdown
Contributor
hartikainen
commented
Feb 16, 2023
hartikainen
commented
I noticed some differences between the mjcf xml schema and the documentation's XML Reference. This fixes two of these differences:
sensor/userelement's attribute defaults. The corresponding change to mujoco was made in google-deepmind/mujoco@221c63d.sizeelement'smemoryattribute. I believe the corrensponding change to mujoco was made in google-deepmind/mujoco@58fd72f.
Also adds two test cases through test_model.xml, which both fail without these schema changes.
hartikainen added 4 commits
February 16, 2023 11:32yuvaltassa approved these changes Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment