Update mjcf schema by hartikainen · Pull Request #380 · google-deepmind/dm_control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@hartikainen

Copy link Copy Markdown

Contributor

I noticed some differences between the mjcf xml schema and the documentation's XML Reference. This fixes two of these differences:

  1. sensor/user element's attribute defaults. The corresponding change to mujoco was made in google-deepmind/mujoco@221c63d.
  2. size element's memory attribute. I believe the corrensponding change to mujoco was made in google-deepmind/mujoco@58fd72f.

Also adds two test cases through test_model.xml, which both fail without these schema changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuvaltassa yuvaltassa yuvaltassa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hartikainen @yuvaltassa