util: use a global symbol for `util.promisify.custom` by ExE-Boss · Pull Request #31672 · nodejs/node
Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: nodejs#31647
ExE-Boss
changed the title
util: Use a global symbol for
util: use a global symbol for util.promisify.customutil.promisify.custom
ExE-Boss added a commit to ExE-Boss/util.promisify that referenced this pull request
Feb 8, 2020Define `util.promisify.custom` as `Symbol.for(nodejs.util.inspect.custom)`, rather than as `Symbol(util.inspect.custom)`. This allows custom `promisify` wrappers to easily/safely be defined in non‑Node.js environments. Refs: nodejs/node#31647 Refs: nodejs/node#31672
ExE-Boss added a commit to EB-Forks/node-util that referenced this pull request
Feb 8, 2020Define `util.promisify.custom` as `Symbol.for(nodejs.util.inspect.custom)`, rather than as `Symbol(util.inspect.custom)`. This allows custom `promisify` wrappers to easily/safely be defined in non‑Node.js environments. Refs: nodejs/node#31647 Refs: nodejs/node#31672
ExE-Boss added a commit to ExE-Boss/util.promisify that referenced this pull request
Feb 8, 2020Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Refs: nodejs/node#31647
Refs: nodejs/node#31672
ExE-Boss added a commit to EB-Forks/node-util that referenced this pull request
Feb 8, 2020Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Refs: nodejs/node#31647
Refs: nodejs/node#31672
ExE-Boss
deleted the
lib/util/use-global-util-promisify-custom-symbol
branch
BridgeAR pushed a commit that referenced this pull request
Mar 17, 2020Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: #31647
PR-URL: #31672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request
Mar 19, 2020Notable changes: * [a44da56] - (SEMVER-MINOR) doc: update stability of report features (Colin Ihrig) #32242 * [306ed96] - (SEMVER-MINOR) doc,lib,src,test: make --experimental-report a nop (Colin Ihrig) #32242 * [ea7f89d] - (SEMVER-MINOR) test: remove common.skipIfReportDisabled() (Colin Ihrig) #32242 * [3f1f518] - (SEMVER-MINOR) build: make --without-report a no-op (Colin Ihrig) #32242 * [36ab39f] - (SEMVER-MINOR) build: remove node_report option in node.gyp (Colin Ihrig) #32242 * [514b7c2] - (SEMVER-MINOR) src: unconditionally include report feature (Colin Ihrig) #32242 * [435fbbc] - (SEMVER-MINOR) worker: allow URL in Worker constructor (Antoine du HAMEL) #31664 * [975d6b0] - (SEMVER-MINOR) util: use a global symbol for `util.promisify.custom` (ExE Boss) #31672
MylesBorins pushed a commit that referenced this pull request
Mar 24, 2020Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: #31647
PR-URL: #31672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request
Mar 24, 2020Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* update npm to 6.14.3 (Myles Borins)
#32368
* update to uvwasi 0.0.6 (Colin Ihrig) [#32309](#32309)
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* node\_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins added a commit that referenced this pull request
Mar 24, 2020Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* update npm to 6.14.3 (Myles Borins)
#32368
* update to uvwasi 0.0.6 (Colin Ihrig) [#32309](#32309)
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* node\_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins added a commit that referenced this pull request
Mar 25, 2020macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* update npm to 6.14.3 (Myles Borins)
#32368
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins added a commit that referenced this pull request
Mar 26, 2020macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins added a commit that referenced this pull request
Mar 26, 2020macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins added a commit that referenced this pull request
Mar 26, 2020macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request
Apr 1, 2020Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: nodejs#31647
PR-URL: nodejs#31672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ExE-Boss added a commit to ExE-Boss/node that referenced this pull request
Apr 1, 2020Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: nodejs#31647
PR-URL: nodejs#31672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request
Apr 2, 2020Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: #31647
Backport-PR-URL: #32349
PR-URL: #31672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ExE-Boss added a commit to ExE-Boss/util.promisify that referenced this pull request
Jan 6, 2021Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Refs: nodejs/node#31647
Refs: nodejs/node#31672
ExE-Boss added a commit to ExE-Boss/util.promisify that referenced this pull request
Jan 6, 2021Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Refs: nodejs/node#31647
Refs: nodejs/node#31672
ljharb pushed a commit to ExE-Boss/util.promisify that referenced this pull request
Jan 6, 2021Define `util.promisify.custom` as `Symbol.for("nodejs.util.inspect.custom")`, rather than as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined in non‑Node.js environments.
Refs: nodejs/node#31647
Refs: nodejs/node#31672
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters