v13.12.0 proposal by MylesBorins · Pull Request #32376 · nodejs/node
Missing from release, apologies. PR-URL: #32218 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
added
build
v13.x labels
Mar 19, 2020
rvagg
mentioned this pull request
4 tasks
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32151 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32213 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #32037 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: #32072 PR-URL: #32073 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #32087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #32125 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: #30056 PR-URL: #30147 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Define `util.promisify.custom`
as `Symbol.for("nodejs.util.inspect.custom")`, rather than
as `Symbol("util.inspect.custom")`.
This allows custom `promisify` wrappers to easily/safely be defined
in non‑Node.js environments.
Fixes: #31647
PR-URL: #31672
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request
Mar 25, 2020macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* update npm to 6.14.3 (Myles Borins)
#32368
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
rvagg
mentioned this pull request
4 tasks
`ObjectTemplate`s are not garbage-collected like regular objects (for some reason). It is sufficient to create a single template anyway, so do that to address the memory leak. Fixes: #32424 PR-URL: #32426 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #32385 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Instead of indicating that examples show lines to change in previous examples, present the examples as standalone items. They suffice on their own. In the first of these, it says to change "the second line" of a previous example, but if it were literally changed to the provided line, it would result in a syntax error. In the second of these, it gives the wrong line to change. All of this is unnecessary and probably makes the examples harder to follow. So simplify and treat each one as a separate example. PR-URL: #32451 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Typo `runAndReturn` -> `runSyncAndReturn` PR-URL: #32382 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. PR-URL: #32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Since the previous sentence describes `10` as a default, and the following sentence explains how to modify that default, it is unnecessary to explain that "Obviously, not all events should be limited to just 10 listeners." PR-URL: #32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #32495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins added a commit that referenced this pull request
Mar 26, 2020macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins added a commit that referenced this pull request
Mar 26, 2020macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
targos
deleted the
v13.12.0-proposal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters