deprecate np.matrix usage by bnavigator · Pull Request #486 · python-control/python-control
Navigation Menu
{{ message }}
python-control / python-control Public
- Notifications You must be signed in to change notification settings
- Fork 453
Merged
murrayrm merged 2 commits intopython-control:masterfrom
Dec 30, 2020Merged
murrayrm merged 2 commits intopython-control:masterfrom
murrayrm merged 2 commits intopython-control:masterfrom
Conversation
Copy link Copy Markdown
Contributor
bnavigator
commented
Dec 29, 2020
bnavigator
commented
As previously discussed and announced: 0.9 deprecates np.matrix usage
Copy link Copy Markdown
coveralls
commented
Dec 30, 2020
coveralls commented
Dec 30, 2020Copy link Copy Markdown
Copy link Copy Markdown
Contributor Author
bnavigator
commented
Dec 30, 2020
bnavigator commented
Dec 30, 2020#438 will handle the CI fail: The warning category changed.
bnavigator
mentioned this pull request
murrayrm approved these changes Dec 30, 2020
Copy link Copy Markdown
Contributor
roryyorke
commented
Dec 30, 2020
roryyorke commented
Dec 30, 2020Assume it's OK to change tests to use np.array instead of np.matrix then? This caught me out while debugging a test failure in canonical_test.py today.
Copy link Copy Markdown
Member
murrayrm
commented
Dec 30, 2020
murrayrm commented
Dec 30, 2020You might want to have a look at #438 and wait until that is merged before making changes to tests (they are undergoing significant refactoring).
We are waiting on CI tests to run, but merges should happen today.
bnavigator added 2 commits
December 30, 2020 21:26
bnavigator
force-pushed
the
deprecate-matrix
branch
from
f9d4a9c to
1565097
Compare
murrayrm
merged commit
ec42737
into
python-control:master
Copy link Copy Markdown
Contributor Author
bnavigator
commented
Dec 30, 2020
bnavigator commented
Dec 30, 2020Now that #438 is merged, this passes. But with removing the filter as discussed #438 (comment) it seems that the actual new default is not set properly during the test suite run.
bnavigator
mentioned this pull request
bnavigator
deleted the
deprecate-matrix
branch
murrayrm
added this to the
0.9.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment