deprecate np.matrix usage by bnavigator · Pull Request #486 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bnavigator

Copy link Copy Markdown

Contributor

As previously discussed and announced: 0.9 deprecates np.matrix usage

@coveralls

Copy link Copy Markdown

Coverage Status

Coverage decreased (-10.01%) to 76.606% when pulling f9d4a9c on bnavigator:deprecate-matrix into 51c797e on python-control:master.

@coveralls

Copy link Copy Markdown

coveralls commented

Dec 30, 2020

edited

Loading

Coverage Status

Coverage remained the same at 87.04% when pulling 1565097 on bnavigator:deprecate-matrix into c432fd5 on python-control:master.

@bnavigator

Copy link Copy Markdown

Contributor Author

#438 will handle the CI fail: The warning category changed.

@roryyorke

Copy link Copy Markdown

Contributor

Assume it's OK to change tests to use np.array instead of np.matrix then? This caught me out while debugging a test failure in canonical_test.py today.

@murrayrm

Copy link Copy Markdown

Member

You might want to have a look at #438 and wait until that is merged before making changes to tests (they are undergoing significant refactoring).

We are waiting on CI tests to run, but merges should happen today.

@murrayrm murrayrm merged commit ec42737 into python-control:master

Dec 30, 2020

@bnavigator

Copy link Copy Markdown

Contributor Author

Now that #438 is merged, this passes. But with removing the filter as discussed #438 (comment) it seems that the actual new default is not set properly during the test suite run.

@bnavigator bnavigator deleted the deprecate-matrix branch

January 5, 2021 20:18

@murrayrm murrayrm added this to the 0.9.0 milestone

Mar 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bnavigator @coveralls @roryyorke @murrayrm