Home Original page

stream: simpler Readable async iterator by ronag · Pull Request #34035 · nodejs/node

@ronag added the stream

Issues and PRs related to the stream subsystem.

label

Jun 23, 2020

ronag

ronag

This was referenced

Jun 24, 2020

benjamingr

ronag added a commit that referenced this pull request

Jul 17, 2020 
Reimplement as an async generator instead of a custom
iterator class.

PR-URL: #34035
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott

@ronag ronag mentioned this pull request

Jul 17, 2020

2 tasks

cjihrig pushed a commit that referenced this pull request

Jul 23, 2020 
Reimplement as an async generator instead of a custom
iterator class.

PR-URL: #34035
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@ronag ronag mentioned this pull request

Aug 8, 2020

@ronag ronag mentioned this pull request

Aug 23, 2020

4 tasks

richardlau pushed a commit that referenced this pull request

Sep 7, 2020 
Reimplement as an async generator instead of a custom
iterator class.

Backport-PR-URL: #34887
PR-URL: #34035
Refs: #34680
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

richardlau pushed a commit that referenced this pull request

Sep 7, 2020 
Reimplement as an async generator instead of a custom
iterator class.

Backport-PR-URL: #34887
PR-URL: #34035
Refs: #34680
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

richardlau added a commit that referenced this pull request

Sep 7, 2020 
Notable changes:

- buffer: also alias BigUInt methods (Anna Henningsen)
  #34960
- crypto: add randomInt function (Oli Lalonde)
  #34600
- perf_hooks: add idleTime and event loop util (Trevor Norris)
  #34938
- stream: simpler and faster Readable async iterator (Robert Nagy)
  #34035
- stream: save error in state (Robert Nagy)
  #34103

PR-URL: #35023

richardlau added a commit that referenced this pull request

Sep 8, 2020 
Notable changes:

- buffer: also alias BigUInt methods (Anna Henningsen)
  #34960
- crypto: add randomInt function (Oli Lalonde)
  #34600
- perf_hooks: add idleTime and event loop util (Trevor Norris)
  #34938
- stream: simpler and faster Readable async iterator (Robert Nagy)
  #34035
- stream: save error in state (Robert Nagy)
  #34103

PR-URL: #35023

Conflicts:
	src/node_version.h

MylesBorins pushed a commit that referenced this pull request

Oct 15, 2020 
includes:

* stream: simpler and faster Readable async iterator
* stream: don't destroy on async iterator success
* stream: async iterator stop read if destroyed

PR-URL: #34887
Refs: #34035
Refs: #35122
Refs: #35640
Refs: #34680
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>