Home Original page

[v14.x backport] stream: simpler and faster Readable async iterator by ronag · Pull Request #34887 · nodejs/node

@ronag added the stream

Issues and PRs related to the stream subsystem.

label

Aug 23, 2020

@ronag ronag changed the title stream: don't emit finish after close [v14.x backport] stream: don't emit finish after close

Aug 23, 2020

@ronag ronag changed the title [v14.x backport] stream: don't emit finish after close [v14.x backport] stream: simpler and faster Readable async iterator

Aug 23, 2020

mcollina

This was referenced

Aug 24, 2020

@mhdawson mhdawson removed the tsc-agenda

Issues and PRs to discuss during the meetings of the TSC.

label

Sep 3, 2020

ronag

ronag added a commit to nxtedition/node that referenced this pull request

Oct 14, 2020 
Fixes some compatibility issues where it is expected
that for await stops reading when the stream is
destroyed.

Refs: nodejs#34887

@ronag ronag mentioned this pull request

Oct 14, 2020

4 tasks

mcollina

MylesBorins pushed a commit that referenced this pull request

Oct 15, 2020 
Fixes some compatibility issues where it is expected
that for await stops reading when the stream is
destroyed.

Refs: #34887

PR-URL: #35640
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 15, 2020 
includes:

* stream: simpler and faster Readable async iterator
* stream: don't destroy on async iterator success
* stream: async iterator stop read if destroyed

PR-URL: #34887
Refs: #34035
Refs: #35122
Refs: #35640
Refs: #34680
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>