Home Original page

stream: async iterator stop read if destroyed by ronag · Pull Request #35640 · nodejs/node

@ronag 

Fixes some compatibility issues where it is expected
that for await stops reading when the stream is
destroyed.

Refs: nodejs#34887

@ronag added stream

Issues and PRs related to the stream subsystem.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Oct 14, 2020

ronag

mcollina

@ronag ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 14, 2020

@ronag ronag mentioned this pull request

Oct 14, 2020

4 tasks

MylesBorins pushed a commit that referenced this pull request

Oct 15, 2020 
Fixes some compatibility issues where it is expected
that for await stops reading when the stream is
destroyed.

Refs: #34887

PR-URL: #35640
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 15, 2020 
includes:

* stream: simpler and faster Readable async iterator
* stream: don't destroy on async iterator success
* stream: async iterator stop read if destroyed

PR-URL: #34887
Refs: #34035
Refs: #35122
Refs: #35640
Refs: #34680
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>