Home Original page

stream: don't destroy on async iterator success by ronag · Pull Request #35122 · nodejs/node

@nodejs-github-bot added the stream

Issues and PRs related to the stream subsystem.

label

Sep 9, 2020

@ronag ronag mentioned this pull request

Sep 9, 2020

This was referenced

Sep 9, 2020

mcollina

ronag

mcollina

addaleax

@ronag ronag added the tsc-agenda

Issues and PRs to discuss during the meetings of the TSC.

label

Sep 21, 2020

@ronag 

Destroying on async iterator completion ignores autoDestroy.

benjamingr

@ronag ronag removed the tsc-agenda

Issues and PRs to discuss during the meetings of the TSC.

label

Sep 21, 2020

mcollina

@ronag ronag added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Sep 21, 2020

nodejs-github-bot pushed a commit that referenced this pull request

Sep 21, 2020 
Destroying on async iterator completion ignores autoDestroy.

PR-URL: #35122
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 15, 2020 
includes:

* stream: simpler and faster Readable async iterator
* stream: don't destroy on async iterator success
* stream: async iterator stop read if destroyed

PR-URL: #34887
Refs: #34035
Refs: #35122
Refs: #35640
Refs: #34680
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request

Jan 8, 2021 
Destroying on async iterator completion ignores autoDestroy.

PR-URL: nodejs#35122
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>